Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Cdn from generation branch #18159

Merged
merged 5 commits into from
May 17, 2022
Merged

Sync Cdn from generation branch #18159

merged 5 commits into from
May 17, 2022

Conversation

wyunchi-ms
Copy link
Contributor

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@BethanyZhou
Copy link
Contributor

  1. For Az.Cdn.psd1, the version of Az.Cdn should be same with hand-crafted one.
  2. For changelog.md, its content should be consistent with previous one with a new proper message.

@BethanyZhou
Copy link
Contributor

BethanyZhou commented May 16, 2022

For readme.md, please use a branch tag to lock the version of swagger file.

Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wyunchi-ms wyunchi-ms merged commit 38d92a8 into main May 17, 2022
@BethanyZhou BethanyZhou deleted the codegen/Cdn branch May 18, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants